Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade swagger #1042

Merged
merged 3 commits into from
May 24, 2018
Merged

Downgrade swagger #1042

merged 3 commits into from
May 24, 2018

Conversation

faboweb
Copy link
Contributor

@faboweb faboweb commented May 23, 2018

for synchronization purposes I downgraded the spec

@faboweb faboweb requested a review from ebuchman as a code owner May 23, 2018 14:37
@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #1042 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1042   +/-   ##
========================================
  Coverage    60.58%   60.58%           
========================================
  Files           79       79           
  Lines         3968     3968           
========================================
  Hits          2404     2404           
  Misses        1405     1405           
  Partials       159      159

@faboweb
Copy link
Contributor Author

faboweb commented May 23, 2018

After merging the API is accessible from https://faboweb.github.io/swagger-ui/develop/index.html
If merged to master it will also be available under https://faboweb.github.io/swagger-ui/

When tested and desired we can put the API on a better URL.

I will try to hook the API up to lite-node in the future so you can test the LCD live.

@faboweb faboweb changed the title WIP: downgrade swagger Downgrade swagger May 23, 2018
@faboweb faboweb changed the base branch from master to develop May 24, 2018 08:30
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 975668a into develop May 24, 2018
@cwgoes cwgoes deleted the fabo/downgrade-swagger-to-v2 branch May 24, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants