Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: livness test #10396

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix: livness test #10396

merged 1 commit into from
Oct 18, 2021

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Oct 18, 2021 •
edited
Loading

Description

Closes: #10385

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review October 18, 2021 09:52
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 18, 2021
@tac0turtle tac0turtle merged commit a95d659 into master Oct 18, 2021
@tac0turtle tac0turtle deleted the liveness-test branch October 18, 2021 09:58
@amaury1093
Copy link
Contributor

Too bad https://github.com/cosmos/cosmos-sdk/pull/10396/checks?check_run_id=3924854864 is skipped, but still fine to merge it

@tac0turtle
Copy link
Member Author

oh whoops. i forgot about this. ill stay tuned to master

liamsi added a commit to celestiaorg/cosmos-sdk that referenced this pull request Apr 20, 2022
@liamsi
replicate cosmos#10396
0fa3271
liamsi added a commit to celestiaorg/cosmos-sdk that referenced this pull request Apr 20, 2022
@liamsi
chore: bump core to 1.1.0 (#118)
eee26c3 
* bump core to 1.1.0

* bump go to 1.17

* replicate cosmos#10396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@odeke-em odeke-em Awaiting requested review from odeke-em

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: liveness test doesn't seem to be using Go1.16+ hence doesn't compile
2 participants
@tac0turtle @amaury1093