Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update contributing guidelines #10223
docs: update contributing guidelines #10223
Changes from 1 commit
1ba7fb1
8b56f04
f050544
3610807
36b31fb
862297f
dd1edb1
7f3153c
22232ea
d9217a4
be26d0d
8add173
8661c19
c87a036
a2c3b4e
e28157a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a note that says something to the effect of "While the SDK is in a pre- 1.0 version, we treat v0.X.0 releases as major releases and the procedure above is followed"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the major release, point release is also a major release. It's an upgrade (possible consensus breaking) which doesn't break the API.
We should have many major releases which are just point releases. And push back in the backlog things that require a big bump (going from x.y -> x+1.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact the original text is correct. "Should" has to be used. Updates which are not related to the upstream, must be created as PR to the release branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, not critical for me... although should is ambiguous... I think we're saying that
(isn't this fun? I can talk word choice all day long, love this stuff!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we say point release, but earlier we use "patch" and "minor release" as terminology as well. Can we explicitly state that they're equivalent, or alternatively distinguish btw them explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I will not use point release.