Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert keeper tests to testsuite #10187

Merged
merged 17 commits into from
Sep 22, 2021

Conversation

NagaTulasi
Copy link
Contributor

Description

Closes: #10046


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #10187 (f98f71e) into master (9ebd12b) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10187      +/-   ##
==========================================
- Coverage   63.72%   63.67%   -0.06%     
==========================================
  Files         573      573              
  Lines       53764    53764              
==========================================
- Hits        34263    34235      -28     
- Misses      17553    17582      +29     
+ Partials     1948     1947       -1     
Impacted Files Coverage Δ
x/mint/keeper/querier.go 2.85% <0.00%> (-71.43%) ⬇️
x/params/keeper/grpc_query.go 73.68% <0.00%> (-10.53%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@NagaTulasi NagaTulasi marked this pull request as ready for review September 17, 2021 09:18
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 22, 2021
@amaury1093 amaury1093 dismissed alexanderbez’s stale review September 22, 2021 09:51

all comments have been addressed

@mergify mergify bot merged commit 58673f8 into cosmos:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth C:x/mint C:x/params
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: convert keeper tests into testsuite
7 participants