authz MsgExec ignores all responses but the last one.

[robert-zaremba]

Summary of Bug

authz/MsgExec takes multiple messages to execute:

type MsgExec struct {
	Grantee string
	// Authorization Msg requests to execute. Each msg must implement Authorization interface
	// The x/authz will try to find a grant matching (msg.signers[0], grantee, MsgTypeURL(msg))
	// triple and validate it.
	Msgs []*types1.Any
}

When dispatching the messages we fail if one of the sub messages fails. However when all succeed, we only return a response from the last message:

cosmos-sdk/x/authz/keeper/keeper.go

Lines 112 to 118 in 0e64fa7

	msgResult, err = handler(ctx, msg)
	if err != nil {
	return nil, sdkerrors.Wrapf(err, "failed to execute message; message %v", msg)
	}
	}
	return msgResult, nil

Version

master, 0.43-beta

Solution proposal

Update MsgExecResponse to get an array of responses.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[aaronc]

Right so instead of sdk.Result, MsgExecResponse should probably be:

message MsgExecResponse {
  repeated google.protobuf.Any responses = 1;
}

I don't know why we need to deal with sdk.Result at all, we don't need to include log and events and those actually could be non-deterministic 😲 .

[robert-zaremba]

Yeap - this is what I did in fact.