Skip to content

wrapper.GetPubKeys silently ignore unpacked keys #8129

Closed
@robert-zaremba

Description

Summary of an Issue

wrapper is a structure which provides TxBuilder functionality. One of the interface methods is GetPubKeys. There is a dangerous, undocumented behavior. wrapper stores signers public keys in a Any structure to support proto marshaling.
We must make sure that whenever we add keys to the wrapper, they should be unpacked, otherwise this can lead to an difficult to catch issues.

Version: v0.40

Proposal

wrapper.GetPubKeys should return internal error.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

C:x/authT: API BreakingBreaking changes that impact APIs and the SDK only (not state machine).T:Bug

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions