Protobuf: make proto-gen does not work

[fdymylja]

While trying to build protobufs files I realized that we have some problems regarding to:

1. in third_party/proto/google we're missing the following files descriptor.proto, timestamp.proto, duration.proto
2. the versions of the files above to use are missing too.
3. make tools does not download protoc-gen-gocosmos and the protoc-gen-grpc-gateway executables suite.

If a correct process of building the protobufs (third_party files version, executables and their versions) was written, I could write a docker image with the tools required to run make proto-all, in order to produce consistent generated golang protobufs. Hence removing the need of going through a lot of installations and risking to mess them all.

[aaronc]

Sorry you're having trouble. 1 has been reported many times and is not a bug. Looks like you just need some help with configuration and maybe better docs. @amaurymartiny ?

[tac0turtle]

Hey a docker setup was merged this morning, there isn't a need to install anything anymore. I recommend using it.

The cmd is: make proto-gen-docker.

[amaury1093]

@fdymylja let us know how the docker setup goes.

We could definitely improve the docs, e.g. in the CONTRIBUTING guide.

It was proposed in #7893 (comment) to remove the make proto-gen target, and only expose the docker one. I think it actually might be a good idea.

[fdymylja]

Thank you for the help, it works.

On a side note, is there a reason for which we're not using $(CURDIR) instead of $(shell pwd) in the makefiles?

PS: Feel free to close whenever you want.

[tac0turtle]

On a side note, is there a reason for which we're not using $(CURDIR) instead of $(shell pwd) in the makefiles?

@alessio is the author of most of these makefiles. He will have the best context.