Skip to content

Staking renaming #3289

Closed
Closed
@rigelrozanski

Description

@rigelrozanski

in the interest of changing APIs prelaunch (sooner than later) as I've been reviewing staking there are a few renames which I think we ought to update:

  • MsgBeginUnbonding -> MsgUndelegate
    • Begin unbonding doesn't really make sense because the validator may be unbonding (in which case the tokens have already begun unbonding) or unbonded (tokens do not enter into an UnbondingDelegation object)
  • field name Delegation -> Amount (these are type sdk.Coins) in MsgCreateValidator and MsgDelegate
    • Delegation is an ambiguous field name because of the Delegation type in x/stake/types/delegation.go
  • Validator.UnbondingMinTime -> Validator.UnbondingCompletionTime stay consistent with unbonding delegation object/thinking

CC @cwgoes @jackzampolin @faboweb

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions