[Bug]: Inconsistent annual-provisions values between v1 and v2 with `--height` flag

[akhilkumarpilli]

Description

There is an inconsistency in the annual-provisions values returned by v1 and v2 when querying with the --height flag. Specifically, when querying at initial block (height=1), v1 returns the expected provision values, while v2 returns 0.000000000000000000. This behavior should be consistent between both versions.

Steps to Reproduce

1. Use the --height flag to query annual-provisions on both v1 and v2 for the same block height.
2. Compare the returned values.

Example:

# Query using simd (v1) with height flag
$ simd q mint annual-provisions -o json --height 1
{
  "annual_provisions": "25000000.000000000000000000"
}

# Query using simdv2 (v2) with the same height flag
$ simdv2 q mint annual-provisions -o json --height 1
{
  "annual_provisions": "0.000000000000000000"
}

# Query using simdv2 (v2) with height 2 for comparison
$ simdv2 q mint annual-provisions -o json --height 2
{
  "annual_provisions": "25000000.000000000000000000"
}

Additional Context

It might be an issue with committing the state at genesis in v2, where height 1 is committed as an empty block.

[julienrbrt]

I'll be looking into this today 👍

[kocubinski]

the v2 genesis flow is definitely confusing, but it doesn't seem to be the cause here. Here's my RCA after a couple hours of debugging:

in app/v1 this line from x/mint (via x/epochs BeginBlock) in BeforeEpochStart is called during the block 1 state transition:

cosmos-sdk/x/mint/epoch_hooks.go

Line 29 in f6d7a92

return am.keeper.Minter.Set(ctx, minter)

This line never gets executed in in app/v2 in block 1 (or ever as far as I can tell), so minter.AnnualProvisions is never mutated until MintFn is called in block 2:

cosmos-sdk/x/mint/keeper/keeper.go

Lines 130 to 131 in f6d7a92

	minter.Inflation = ic(ctx, *minter, params, bondedRatio)
	minter.AnnualProvisions = minter.NextAnnualProvisions(params, stakingTokenSupply)

So the root cause seems to be x/epoch BeginBlockers not be called in app/v2. Hope this helps.