Skip to content

[Refactor]: x/auth/tx and x/tx should converge on gogoproto usage. #20431

Open

Description

There is duplicate logic in both x/tx/decode and the x/auth/tx packages. Since the decision to support gogoproto throughout the SDK (as specified in core/transaction below)

Msg = gogoproto.Message

These two packages can be simplified and collapsed into one simple implementation in x/tx. An initial exploration of this was done here in #20424 and integrated in #20428.

The result will be a lot of deleted code and much less mental overhead when reasoning about transactions in the SDK. The signing code in x/tx can and should remain the same, as shown in #20424 reflection over gogotypes as input is possible through the use of dynamic messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

C:x/txS:needs rfcNeeds an RFC to inform community over those changesS:zondaxSquad: Zondax

Type

No type

Projects

  • Status

    📋 Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions