some accepts/implements annotations don't resolve to existing scopes

[pyramation]

I've gone over every accepts/implements interface and found some discrepancies.

I've parsed the accepts and implements and analyzed every possible lookups that the Go interpreter will lookup based on the .proto and the name used in the annotation (link to the Go protobuf scope lookup algorithm)

If I misunderstood something, please let me know!

Here are the bad protos that I've found

• cosmos/bank/v1beta1/authz.proto (SendAuthorization)
  Required scope: cosmos.authz.Authorization
  Possible lookup scopes:

cosmos.bank.v1beta1.Authorization
cosmos.bank.Authorization
cosmos.Authorization
Authorization

• cosmos/gov/v1/tx.proto (MsgExecLegacyContent)
  Required scope: cosmos.gov.v1beta1.Content? (does v1 point to v1beta1 Content interface?)
  Possible lookup scopes:

cosmos.gov.v1.Content
cosmos.gov.Content
cosmos.Content
Content

• cosmos/group/v1/tx.proto (MsgCreateGroupPolicy, MsgCreateGroupWithPolicy, MsgUpdateGroupPolicyDecisionPolicy)
  Required scope: cosmos.group.DecisionPolicy
  Possible lookup scopes:

cosmos.group.v1.cosmos.group.v1.DecisionPolicy
cosmos.group.cosmos.group.v1.DecisionPolicy
cosmos.cosmos.group.v1.DecisionPolicy
cosmos.group.v1.DecisionPolicy

• cosmos/staking/v1beta1/authz.proto (StakeAuthorization)
  Required scope: cosmos.authz.Authorization
  Possible lookup scopes:

cosmos.staking.v1beta1.Authorization
cosmos.staking.Authorization
cosmos.Authorization
Authorization

[amaury1093]

Thanks @pyramation!

If we agree to go with full-scoped names, I propose to update all SDK's proto files with these changes:

• Authorization -> cosmos.authz.v1beta1.Authorization
• Content -> cosmos.gov.v1beta1.Content

Edit: I found a couple more:

• AccountI -> cosmos.auth.v1beta1.AccountI
• DecisionPolicy -> cosmos.group.v1.DecisionPolicy
• ModuleAccountI -> cosmos.auth.v1beta1.ModuleAccountI
• FeeAllowanceI -> cosmos.feegrant.v1beta1.FeeAllowanceI
• SupplyI -> cosmos.bank.v1beta1.SupplyI

[pyramation]

I think fully-scoped names will solve the issue and remove ambiguity for new packages that use interfaces.

docs that may need updating after this change:

• https://github.com/regen-network/cosmos-proto#implements_interface
• https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/core/05-encoding.md#interface-encoding-and-usage-of-any