TEXTUAL public keys value renderer

## Summary

Part of #11970 

Define how public keys should be value-rendered in SIGN_MODE_TEXTUAL.

## Problem Definition

We didnt' define public keys value renderers in ADR-050. Currently, they would be displayed as normal messages (i.e. Proposal 1). 

Which high-level format should we display pubkeys in (bytes, or a struct)?

Recall, we mainly have 3 types of pubkeys: secp256k1, ed25519 and legacy multisigs.

## Proposal 1

No custom value renderer for pubkeys. We would have:

```
* PubKey object
*> Key: 123ABC
```

ref: https://github.com/cosmos/cosmos-sdk/blob/209797f3be8e397e453cb1b2cbca2bfa57dec0ee/proto/cosmos/crypto/secp256k1/keys.proto#L13-L17

Pro: visibility into sub pubkeys
cons: longer screens

## Proposal 2

Use the [`Bytes()` method](https://github.com/cosmos/cosmos-sdk/blob/209797f3be8e397e453cb1b2cbca2bfa57dec0ee/crypto/types/types.go#L25) on the pubkey interface.

Rendered:

```
*Public key: 123ABC
```

Small Pro: people are used to this `Bytes()` method, albeit in base64 format
Big con: this would rely on Amino, because of LegacyMultisig:
https://github.com/cosmos/cosmos-sdk/blob/209797f3be8e397e453cb1b2cbca2bfa57dec0ee/crypto/keys/multisig/multisig.go#L42-L45

## Proposal 3

Define something completely new.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEXTUAL public keys value renderer #13626

amaury1093
openedon Oct 24, 2022

Summary

Problem Definition

Proposal 1

Proposal 2

Proposal 3

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	message PubKey {
	option (gogoproto.goproto_stringer) = false;

	bytes key = 1;
	}

	// Bytes returns the proto encoded version of the LegacyAminoPubKey
	func (m *LegacyAminoPubKey) Bytes() []byte {
	return AminoCdc.MustMarshal(m)
	}