x/auth: GetTxsEvent gRPC method does not work with signatures

[technicallyty]

Summary of Bug

GetTxsEvent does not work when querying by signature. In order to query by signature, the sig bytes are base64 encoded, which often has multiple = signs in the string encoding. The GetTxsEvent method, however, fails if there is more than one = sign in the request: https://github.com/cosmos/cosmos-sdk/blob/main/x/auth/tx/service.go#L72

Version

since: 7c19434 to master

Steps to Reproduce

example failing test here:

cosmos-sdk/x/auth/tx/service_test.go

Line 696 in 79bbba8

func (s IntegrationTestSuite) TestQueryBySig() {

1. build transaction
2. broadcast tx
3. extract signature from builder
4. base64 encode signature
5. format event string tx.signature='base64EncodedSignature'
6. call GetTxsEvent grpc method

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[aaronc]

I wonder if we can use url escaping to fix this

[technicallyty]

I wonder if we can use url escaping to fix this

i did try that but did not find success unfortunately

[alexanderbez]

I wonder if we can use url escaping to fix this

i did try that but did not find success unfortunately

Mhhh that's odd. The GetTxsEvent gRPC service method takes events as a query param, which should allow escaping of any character. When you escaped the characters, do you know by any chance what the method interpreted the query value as?

EDIT: Ahh, I see the error is invalid event; event %s should be of the format: %s which means this is getting hit:

		if !strings.Contains(event, "=") || strings.Count(event, "=") > 1 {
			return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("invalid event; event %s should be of the format: %s", event, eventFormat))
		}

@aaronc perhaps we need to remove strings.Count(event, "=") > 1

[technicallyty]

I wonder if we can use url escaping to fix this

i did try that but did not find success unfortunately

Mhhh that's odd. The GetTxsEvent gRPC service method takes events as a query param, which should allow escaping of any character. When you escaped the characters, do you know by any chance what the method interpreted the query value as?

EDIT: Ahh, I see the error is invalid event; event %s should be of the format: %s which means this is getting hit:

		if !strings.Contains(event, "=") || strings.Count(event, "=") > 1 {
			return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("invalid event; event %s should be of the format: %s", event, eventFormat))
		}

@aaronc perhaps we need to remove strings.Count(event, "=") > 1

maybe we do a regex that asserts the event string is {alphas}.{alphas}={anything} ?