Description
#11533 introduced a new SignMode enum variant called simply EIP191. However, this name is not precise enough. EIP 191 simply refers to a method of encoding a string data to be signed.
However, the Sign Mode concept in Cosmos SDK also refers to how to encode a tx into a string in the first place.
For this reason, in the osmosis-labs version of this, we specifically call this "EIP191LegacyJSON" to signal that it is the EIP191 re-encoded version of the Amino JSON string.
In the future, we will probably want more EIP191 sign modes, such as an EIP191Textual which wraps SignModeTextual.
I think any new sign modes should have an associated ADR for them. For example, in the case of EIP191LegacyJSON, we would also need to standardize how to format the amino json (such as adding new lines and indents) before putting it through the EIP191 conversion.
For this reason, the current sign mode called EIP191 needs to be renamed to avoid confusion. If renaming it is not possible, then it should be deprecated and replaced with a properly named variant.
@AmauryM @fedekunze @alexanderbez
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged
- Contributor assigned/self-assigned
Activity