Remove print response flag (#4593)

This flag isn't used anywhere and probably hasn't for quite some time.

.pending/improvements/sdk/Remove---print-respo

@@ -0,0 +1 @@
+Remove `--print-response` flag as it is no longer used.

client/alias.go

@@ -43,7 +43,6 @@ const (
 	FlagFees               = flags.FlagFees
 	FlagGasPrices          = flags.FlagGasPrices
 	FlagBroadcastMode      = flags.FlagBroadcastMode
-	FlagPrintResponse      = flags.FlagPrintResponse
 	FlagDryRun             = flags.FlagDryRun
 	FlagGenerateOnly       = flags.FlagGenerateOnly
 	FlagIndentResponse     = flags.FlagIndentResponse

client/context/context.go

@@ -43,7 +43,6 @@ type CLIContext struct {
 	TrustNode     bool
 	UseLedger     bool
 	BroadcastMode string
-	PrintResponse bool
 	Verifier      tmlite.Verifier
 	VerifierHome  string
 	Simulate      bool
@@ -91,7 +90,6 @@ func NewCLIContextWithFrom(from string) CLIContext {
 		TrustNode:     viper.GetBool(flags.FlagTrustNode),
 		UseLedger:     viper.GetBool(flags.FlagUseLedger),
 		BroadcastMode: viper.GetString(flags.FlagBroadcastMode),
-		PrintResponse: viper.GetBool(flags.FlagPrintResponse),
 		Verifier:      verifier,
 		Simulate:      viper.GetBool(flags.FlagDryRun),
 		GenerateOnly:  genOnly,

client/flags/flags.go

@@ -45,7 +45,6 @@ const (
 	FlagFees               = "fees"
 	FlagGasPrices          = "gas-prices"
 	FlagBroadcastMode      = "broadcast-mode"
-	FlagPrintResponse      = "print-response"
 	FlagDryRun             = "dry-run"
 	FlagGenerateOnly       = "generate-only"
 	FlagIndentResponse     = "indent"
@@ -96,7 +95,6 @@ func PostCommands(cmds ...*cobra.Command) []*cobra.Command {
 		c.Flags().Bool(FlagUseLedger, false, "Use a connected Ledger device")
 		c.Flags().Float64(FlagGasAdjustment, DefaultGasAdjustment, "adjustment factor to be multiplied against the estimate returned by the tx simulation; if the gas limit is set manually this flag is ignored ")
 		c.Flags().StringP(FlagBroadcastMode, "b", BroadcastSync, "Transaction broadcasting mode (sync|async|block)")
-		c.Flags().Bool(FlagPrintResponse, true, "return tx response (only works with async = false)")
 		c.Flags().Bool(FlagTrustNode, true, "Trust connected full node (don't verify proofs for responses)")
 		c.Flags().Bool(FlagDryRun, false, "ignore the --gas flag and perform a simulation of a transaction, but don't broadcast it")
 		c.Flags().Bool(FlagGenerateOnly, false, "Build an unsigned transaction and write it to STDOUT (when enabled, the local Keybase is not accessible and the node operates offline)")