review changes

cosmos · Jul 6, 2022 · 5545572 · 5545572
1 parent be784e2
commit 5545572
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 19 deletions.
diff --git a/api/cosmos/app/v1alpha1/config.pulsar.go b/api/cosmos/app/v1alpha1/config.pulsar.go
diff --git a/api/cosmos/distribution/v1beta1/genesis.pulsar.go b/api/cosmos/distribution/v1beta1/genesis.pulsar.go
diff --git a/api/cosmos/distribution/v1beta1/tx_grpc.pb.go b/api/cosmos/distribution/v1beta1/tx_grpc.pb.go
diff --git a/proto/cosmos/distribution/v1beta1/genesis.proto b/proto/cosmos/distribution/v1beta1/genesis.proto
@@ -112,6 +112,7 @@ message GenesisState {
   option (gogoproto.equal)           = false;
   option (gogoproto.goproto_getters) = false;
 
+  // params defines all the parameters of the module.
   Params params = 1 [(gogoproto.nullable) = false];
 
   // fee_pool defines the fee pool at genesis.

diff --git a/proto/cosmos/distribution/v1beta1/tx.proto b/proto/cosmos/distribution/v1beta1/tx.proto
@@ -29,7 +29,7 @@ service Msg {
   rpc FundCommunityPool(MsgFundCommunityPool) returns (MsgFundCommunityPoolResponse);
 
   // UpdateParams defines a governance operation for updating the x/distribution module
-  // parameters. The authority is hard-coded to the x/gov module account.
+  // parameters. The authority is defined in the keeper.
   //
   // Since: cosmos-sdk 0.47
   rpc UpdateParams(MsgUpdateParams) returns (MsgUpdateParamsResponse);

diff --git a/x/distribution/keeper/params.go b/x/distribution/keeper/params.go
@@ -24,7 +24,10 @@ func (k Keeper) SetParams(ctx sdk.Context, params types.Params) error {
 	}
 
 	store := ctx.KVStore(k.storeKey)
-	bz := k.cdc.MustMarshal(&params)
+	bz, err := k.cdc.Marshal(&params)
+	if err != nil {
+		return err
+	}
 	store.Set(types.ParamsKey, bz)
 
 	return nil

diff --git a/x/distribution/types/genesis.pb.go b/x/distribution/types/genesis.pb.go
diff --git a/x/distribution/types/tx.pb.go b/x/distribution/types/tx.pb.go