Address comments

cosmos · Feb 4, 2020 · 4348cba · 4348cba
1 parent 79513fc
commit 4348cba
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/docs/architecture/adr-013-metrics.md b/docs/architecture/adr-013-metrics.md
@@ -18,7 +18,7 @@ Extending `AppModuleBasic` to support registering of metrics would enable develo
 type AppModuleBasic interface {
   Name() string
   RegisterCodec(*codec.Codec)
-  + RegisterMetrics(namespace string, labelsAndValues ...string) *Metrics
+  RegisterMetrics(namespace string, labelsAndValues ...string) *Metrics
 
   // genesis
   DefaultGenesis() json.RawMessage
@@ -38,17 +38,19 @@ func (bm BasicManager) RegisterMetrics(appName) MetricsProvider {
 }
 ```
 
-Each module will could define its own `PrometheusMetrics` function:
+Each module can define its own `CreateMetrics` function:
 
 ```go
 type Metrics struct {
   Size metrics.Guage
+
+  Transactions metrics.Counter
 }
 
-func PrometheusMetrics(namespace string, labelsAndValues ...string) *Metrics {
-  labels := []string{}
-	for i := 0; i < len(labelsAndValues); i += 2 {
-		labels = append(labels, labelsAndValues[i])
+func CreateMetrics(namespace string, labelsAndValues ...string) *Metrics {
+  labels := make([]string, len(labelsAndValues/2))
+  for i := 0; i < len(labelsAndValues); i += 2 {
+      labels[i/2] = labelsAndValues[i]
   }
   return &Metrics{
     Size: prometheus.NewGaugeFrom(stdprometheus.GaugeOpts{