Merge branch 'develop'

cosmos · Jul 11, 2018 · 3f44589 · 3f44589
2 parents 5038bf5 + b195c55
commit 3f44589
Show file tree

Hide file tree

Showing 403 changed files with 26,708 additions and 12,698 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -8,6 +8,7 @@ defaults: &defaults
     GOBIN: /tmp/workspace/bin
 
 jobs:
+
   setup_dependencies:
     <<: *defaults
     steps:
@@ -27,12 +28,6 @@ jobs:
           command: |
             export PATH="$GOBIN:$PATH"
             make get_vendor_deps
-      - run:
-          name: linter
-          command: |
-            export PATH="$GOBIN:$PATH"
-            go get -u github.com/tendermint/lint/golint
-            go get -u github.com/alecthomas/gometalinter
       - run:
           name: binaries
           command: |
@@ -55,7 +50,7 @@ jobs:
 
   lint:
     <<: *defaults
-    parallelism: 4
+    parallelism: 1
     steps:
       - attach_workspace:
           at: /tmp/workspace
@@ -64,27 +59,16 @@ jobs:
       - restore_cache:
           key: v1-tree-{{ .Environment.CIRCLE_SHA1 }}
       - run:
-          name: Lint source
+          name: Get metalinter
           command: |
             export PATH="$GOBIN:$PATH"
-            gometalinter --disable-all --enable='golint' --vendor ./...
-  
-  test_unit:
-    <<: *defaults
-    parallelism: 4
-    steps:
-      - attach_workspace:
-          at: /tmp/workspace
-      - restore_cache:
-          key: v1-pkg-cache
-      - restore_cache:
-          key: v1-tree-{{ .Environment.CIRCLE_SHA1 }}
+            make get_tools
       - run:
-          name: Test unit
+          name: Lint source
           command: |
             export PATH="$GOBIN:$PATH"
-            make test_unit
-  
+            make test_lint
+
   test_cli:
     <<: *defaults
     parallelism: 1
@@ -100,17 +84,18 @@ jobs:
           command: |
             export PATH="$GOBIN:$PATH"
             make test_cli
-  
+
   test_cover:
     <<: *defaults
-    parallelism: 4
+    parallelism: 2
     steps:
       - attach_workspace:
           at: /tmp/workspace
       - restore_cache:
           key: v1-pkg-cache
       - restore_cache:
           key: v1-tree-{{ .Environment.CIRCLE_SHA1 }}
+      - run: mkdir -p /tmp/logs
       - run:
           name: Run tests
           command: |
@@ -119,15 +104,18 @@ jobs:
             for pkg in $(go list github.com/cosmos/cosmos-sdk/... | grep -v /vendor/ | grep -v github.com/cosmos/cosmos-sdk/cmd/gaia/cli_test | circleci tests split --split-by=timings); do
               id=$(basename "$pkg")
 
-              go test -timeout 5m -race -coverprofile=/tmp/workspace/profiles/$id.out -covermode=atomic "$pkg"
+              GOCACHE=off go test -v -timeout 8m -race -coverprofile=/tmp/workspace/profiles/$id.out -covermode=atomic "$pkg" | tee "/tmp/logs/$id-$RANDOM.log"
             done
       - persist_to_workspace:
           root: /tmp/workspace
           paths:
             - "profiles/*"
+      - store_artifacts:
+          path: /tmp/logs
 
   upload_coverage:
     <<: *defaults
+    parallelism: 1
     steps:
       - attach_workspace:
           at: /tmp/workspace
@@ -157,9 +145,6 @@ workflows:
       - test_cli:
           requires:
             - setup_dependencies
-      - test_unit:
-          requires:
-            - setup_dependencies
       - test_cover:
           requires:
             - setup_dependencies

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -0,0 +1,7 @@
+# CODEOWNERS: https://help.github.com/articles/about-codeowners/
+
+# Primary repo maintainers
+*       @ebuchman @rigelrozanski @cwgoes
+
+# Precious documentation
+/docs/  @zramsay @jolesbi
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -10,3 +10,4 @@ v    If a checkbox is n/a - please still include it but + a little note why
 * [ ] Updated CHANGELOG.md
 * [ ] Updated Gaia/Examples
 * [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
+* [ ] Added appropriate labels to PR (ex. wip, ready-for-review, docs)
diff --git a/.gitignore b/.gitignore
@@ -3,6 +3,7 @@
 *.swp
 *.swo
 .vscode
+.idea
 
 # Build
 vendor
@@ -15,6 +16,7 @@ docs/_build
 examples/basecoin/app/data
 baseapp/data/*
 client/lcd/keys/*
+mytestnet
 
 # Testing
 coverage.txt
@@ -26,5 +28,9 @@ profile.out
 *.log
 vagrant
 
+# IDE
+.idea/
+*.iml
+
 # Graphviz
 dependency-graph.png
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,14 +1,139 @@
 # Changelog
 
-## 0.19.1
+## 0.20.0
 
-*June 25, 2018*
+*July 10th, 2018*
 
-* Update to Tendermint v0.21.0 (fixes websocket memory leak and a few other
-  things)
+BREAKING CHANGES
+* msg.GetSignBytes() returns sorted JSON (by key)
+* msg.GetSignBytes() field changes
+    * `msg_bytes` -> `msgs`
+    * `fee_bytes` -> `fee`
+* Update Tendermint to v0.22.2
+    * Default ports changed from 466xx to 266xx
+    * Amino JSON uses type names instead of prefix bytes
+    * ED25519 addresses are the first 20-bytes of the SHA256 of the raw 32-byte
+      pubkey (Instead of RIPEMD160)
+    * go-crypto, abci, tmlibs have been merged into Tendermint
+      * The keys sub-module is now in the SDK
+    * Various other fixes
+* [auth] Signers of a transaction now only sign over their own account and sequence number
+* [auth] Removed MsgChangePubKey
+* [auth] Removed SetPubKey from account mapper
+* [auth] AltBytes renamed to Memo, now a string, max 100 characters, costs a bit of gas
+* [baseapp] NewBaseApp now takes option functions as parameters
+* [types] `GetMsg()` -> `GetMsgs()` as txs wrap many messages
+* [types] Removed GetMemo from Tx (it is still on StdTx)
+* [types] renamed rational.Evaluate to rational.Round{Int64, Int}
+* [types] Renamed `sdk.Address` to `sdk.AccAddress`/`sdk.ValAddress`
+* [types] `sdk.AccAddress`/`sdk.ValAddress` natively marshals to Bech32 in String, Sprintf (when used with `%s`), and MarshalJSON
+* [keys] Keybase and Ledger support from go-crypto merged into the SDK in the `crypto` folder
+* [cli] Rearranged commands under subcommands
+* [x/slashing] Update slashing for unbonding period
+  * Slash according to power at time of infraction instead of power at
+    time of discovery
+  * Iterate through unbonding delegations & redelegations which contributed
+    to an infraction, slash them proportional to their stake at the time
+  * Add REST endpoint to unrevoke a validator previously revoked for downtime
+  * Add REST endpoint to retrieve liveness signing information for a validator
+* [x/stake] Remove Tick and add EndBlocker
+* [x/stake] most index keys nolonger hold a value - inputs are rearranged to form the desired key
+* [x/stake] store-value for delegation, validator, ubd, and red do not hold duplicate information contained store-key
+* [x/stake] Introduce concept of unbonding for delegations and validators
+  * `gaiacli stake unbond` replaced with `gaiacli stake begin-unbonding`
+  * Introduced:
+    * `gaiacli stake complete-unbonding`
+    * `gaiacli stake begin-redelegation`
+    * `gaiacli stake complete-redelegation`
+* [lcd] Switch key creation output to return bech32
+* [lcd] Removed shorthand CLI flags (`a`, `c`, `n`, `o`)
+* [gaiad] genesis transactions now use bech32 addresses / pubkeys
+
+DEPRECATED
+* [cli] Deprecated `--name` flag in commands that send txs, in favor of `--from`
 
-BREAKING CHANGES:
-* Changes the default ports from `4665X` to `2665X`
+FEATURES
+* [x/gov] Implemented MVP
+  * Supported proposal types: just binary (pass/fail) TextProposals for now
+  * Proposals need deposits to be votable; deposits are burned if proposal fails
+  * Delegators delegate votes to validator by default but can override (for their stake)
+* [gaiacli] Ledger support added
+  - You can now use a Ledger with `gaiacli --ledger` for all key-related commands
+  - Ledger keys can be named and tracked locally in the key DB
+* [gaiacli] You can now attach a simple text-only memo to any transaction, with the `--memo` flag
+* [gaiacli] added the following flags for commands that post transactions to the chain:
+  * async -- send the tx without waiting for a tendermint response
+  * json  -- return the output in json format for increased readability
+  * print-response -- return the tx response. (includes fields like gas cost)
+* [lcd] Queried TXs now include the tx hash to identify each tx
+* [mockapp] CompleteSetup() no longer takes a testing parameter
+* [x/bank] Add benchmarks for signing and delivering a block with a single bank transaction
+  * Run with `cd x/bank && go test --bench=.`
+* [tools] make get_tools installs tendermint's linter, and gometalinter
+* [tools] Switch gometalinter to the stable version
+* [tools] Add the following linters
+  * misspell
+  * gofmt
+  * go vet -composites=false
+  * unconvert
+  * ineffassign
+  * errcheck
+  * unparam
+  * gocyclo
+* [tools] Added `make format` command to automate fixing misspell and gofmt errors.
+* [server] Default config now creates a profiler at port 6060, and increase p2p send/recv rates
+* [types] Switches internal representation of Int/Uint/Rat to use pointers
+* [types] Added MinInt and MinUint functions
+* [gaiad] `unsafe_reset_all` now resets addrbook.json
+* [democoin] add x/oracle, x/assoc
+* [tests] created a randomized testing framework. 
+  - Currently bank has limited functionality in the framework
+  - Auth has its invariants checked within the framework
+* [x/stake] Allow validator to be created with starting delegation by a third-party delegator on behalf of validator.
+* [tests] Add WaitForNextNBlocksTM helper method
+* [keys] New keys now have 24 word recovery keys, for heightened security
+
+IMPROVEMENTS
+* [x/bank] Now uses go-wire codec instead of 'encoding/json'
+* [x/auth] Now uses go-wire codec instead of 'encoding/json'
+* revised use of endblock and beginblock
+* [stake] module reorganized to include `types` and `keeper` package
+* [stake] keeper always loads the store (instead passing around which doesn't really boost efficiency)
+* [stake] edit-validator changes now can use the keyword [do-not-modify] to not modify unspecified `--flag` (aka won't set them to `""` value)
+* [stake] offload more generic functionality from the handler into the keeper
+* [types] added common tag constants
+* [keys] improve error message when deleting non-existent key
+* [gaiacli] improve error messages on `send` and `account` commands
+* added contributing guidelines
+* [docs] Added commands for governance CLI on testnet README
+
+BUG FIXES
+* [x/slashing] \#1510 Unrevoked validators cannot un-revoke themselves
+* [x/stake] \#1513 Validators slashed to zero power are unbonded and removed from the store
+* [x/stake] \#1567 Validators decreased in power but not unbonded are now updated in Tendermint
+* [x/stake] error strings lower case
+* [x/stake] pool loose tokens now accounts for unbonding and unbonding tokens not associated with any validator
+* [x/stake] fix revoke bytes ordering (was putting revoked candidates at the top of the list)
+* [x/stake] bond count was counting revoked validators as bonded, fixed
+* [gaia] Added self delegation for validators in the genesis creation
+* [lcd] tests now don't depend on raw json text
+* Retry on HTTP request failure in CLI tests, add option to retry tests in Makefile
+* Fixed bug where chain ID wasn't passed properly in x/bank REST handler, removed Viper hack from ante handler
+* Fixed bug where `democli account` didn't decode the account data correctly
+* \#872  - recovery phrases no longer all end in `abandon`
+* \#887  - limit the size of rationals that can be passed in from user input
+* \#1052 - Make all now works
+* \#1258 - printing big.rat's can no longer overflow int64
+* \#1259 - fix bug where certain tests that could have a nil pointer in defer
+* \#1343 - fixed unnecessary parallelism in CI
+* \#1353 - CLI: Show pool shares fractions in human-readable format
+* \#1367 - set ChainID in InitChain
+* \#1461 - CLI tests now no longer reset your local environment data
+* \#1505 - `gaiacli stake validator` no longer panics if validator doesn't exist
+* \#1565 - fix cliff validator persisting when validator set shrinks from max
+* \#1287 - prevent zero power validators at genesis
+* [x/stake] fix bug when unbonding/redelegating using `--shares-percent`
+* \#1010 - two validators can't bond with the same pubkey anymore
 
 
 ## 0.19.0
@@ -18,26 +143,34 @@ BREAKING CHANGES:
 BREAKING CHANGES
 * msg.GetSignBytes() now returns bech32-encoded addresses in all cases
 * [lcd] REST end-points now include gas
+* sdk.Coin now uses sdk.Int, a big.Int wrapper with 256bit range cap
 
 FEATURES
 * [x/auth] Added AccountNumbers to BaseAccount and StdTxs to allow for replay protection with account pruning
+* [lcd] added an endpoint to query for the SDK version of the connected node
 
 IMPROVEMENTS
 * export command now writes current validator set for Tendermint
 * [tests] Application module tests now use a mock application
 * [gaiacli] Fix error message when account isn't found when running gaiacli account
 * [lcd] refactored to eliminate use of global variables, and interdependent tests
+* [tests] Added testnet command to gaiad
+* [tests] Added localnet targets to Makefile
 * [x/stake] More stake tests added to test ByPower index
 
 FIXES
 * Fixes consensus fault on testnet - see postmortem [here](https://github.com/cosmos/cosmos-sdk/issues/1197#issuecomment-396823021)
-* [x/stake] bonded inflation removed, non-bonded inflation partially implemented 
+* [x/stake] bonded inflation removed, non-bonded inflation partially implemented
 * [lcd] Switch to bech32 for addresses on all human readable inputs and outputs
 * [lcd] fixed tx indexing/querying
 * [cli] Added `--gas` flag to specify transaction gas limit
 * [gaia] Registered slashing message handler
 * [x/slashing] Set signInfo.StartHeight correctly for newly bonded validators
 
+FEATURES
+* [docs] Reorganize documentation
+* [docs] Update staking spec, create WIP spec for slashing, and fees
+
 ## 0.18.0
 
 *June 9, 2018*