Skip to content

Commit

Permalink
feat(x/gov): extend governance config (#18428)
Browse files Browse the repository at this point in the history
(cherry picked from commit 89296cc)

# Conflicts:
#	CHANGELOG.md
#	api/cosmos/gov/module/v1/module.pulsar.go
#	proto/cosmos/gov/module/v1/module.proto
#	x/gov/go.mod
#	x/gov/go.sum
#	x/gov/keeper/keeper.go
  • Loading branch information
emidev98 authored and mergify[bot] committed Nov 10, 2023
1 parent dc30a6a commit 092bac2
Show file tree
Hide file tree
Showing 12 changed files with 1,701 additions and 22 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Improvements

<<<<<<< HEAD
=======
* (x/gov) [#18428](https://github.com/cosmos/cosmos-sdk/pull/18428) Extend governance config
* (x/gov) [#18189](https://github.com/cosmos/cosmos-sdk/pull/18189) Limit the accepted deposit coins for a proposal to the minimum proposal deposit denoms.
>>>>>>> 89296ccdd (feat(x/gov): extend governance config (#18428))
* (x/gov) [#18025](https://github.com/cosmos/cosmos-sdk/pull/18025) Improve `<appd> q gov proposer` by querying directly a proposal instead of tx events. It is an alias of `q gov proposal` as the proposer is a field of the proposal.
* (version) [#18063](https://github.com/cosmos/cosmos-sdk/pull/18063) Allow to define extra info to be displayed in `<appd> version --long` command.
Expand Down
145 changes: 145 additions & 0 deletions api/cosmos/gov/module/v1/module.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 13 additions & 1 deletion proto/cosmos/gov/module/v1/module.proto
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,16 @@ message Module {

// authority defines the custom module authority. If not set, defaults to the governance module.
string authority = 2;
}
<<<<<<< HEAD

Check failure on line 19 in proto/cosmos/gov/module/v1/module.proto

View workflow job for this annotation

GitHub Actions / lint

syntax error: unexpected '<'
}
=======

// max_title_len defines the maximum proposal title length.
// Defaults to 255 if not explicitly set.
uint64 max_title_len = 3;

// max_summary_len defines the maximum proposal summary length.
// Defaults to 10200 if not explicitly set.
uint64 max_summary_len = 4;
}
>>>>>>> 89296ccdd (feat(x/gov): extend governance config (#18428))

Check failure on line 31 in proto/cosmos/gov/module/v1/module.proto

View workflow job for this annotation

GitHub Actions / lint

invalid syntax in integer value: 89296ccdd

Check failure on line 31 in proto/cosmos/gov/module/v1/module.proto

View workflow job for this annotation

GitHub Actions / lint

invalid character
4 changes: 2 additions & 2 deletions x/gov/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,8 @@ the following `JSON` template:

This makes it far easier for clients to support multiple networks.

The metadata has a maximum length that is chosen by the app developer, and
passed into the gov keeper as a config. The default maximum length in the SDK is 255 characters.
Fields metadata, title and summary have a maximum length that is chosen by the app developer, and
passed into the gov keeper as a config. The default maximum length are: for the title 255 characters, for the metadata 255 characters and for summary 10200 characters (40 times the one of the title).

#### Writing a module that uses governance

Expand Down
Loading

0 comments on commit 092bac2

Please sign in to comment.