run eslint from monorepo root

[dynst]

Unless there's a good reason not to run eslint on the whole repo?

[webmaster128]

During development it can be handy to be able to run lint only in the package you are currently working in, especially as I cannot get the UI integration to work with yarn at the moment. Linting takes quite some time. Is there a way to restrict the lint to a single package in this setup?

[dynst]

Yeah, I noticed that, so I was just doing:

yarn run eslint --fix packages/crypto/

To restrict to a specific directory.

[webmaster128]

In eslint/eslint#16960 there is a good amount of users complaining about the suggestion to centralize eslint config in a repo root file. It seems like this feedback was not expected when the flat config system was developed. But starting with eslint 10 there is a new resolution system that looks up the config in the current directory and then moves up.
https://eslint.org/docs/latest/use/configure/configuration-files#experimental-configuration-file-resolution

For us I think it is not a big deal to move everything to repo root. Linting per package is not really needed and possible by calls as you showed above.

So from my point of view we can proceed here and get this work ready for merge.

Thank you!

[dynst]

I think this has to wait on the .eslintrc.js changes in #1740 (so typescript lints aren't run on the .js files in scripts/)

[webmaster128]

Wasn't this PR supposed to remove all the "lint" scripts from the packages in favour of the top levels lint?

[dynst]

Yep, just had to rebase the last commit against recent changes first. Wanted to see if the early non-conflicting commits passed CI