Add memo field to AminoMsgTransfer #1456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff LGTM. Unfortunately we cannot easily test it against a chain because simapp does not have IBC anymore. Could you please allow modification from maintainers? Then I can add a CHANGELOG entry and merge. |
|
Ping |
Can you check now? |
|
Amino support for the MsgTransfer memo should work as of 0.31.3, released today. See #1493 for an overview of the state of affairs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables Packet Forwarding Middleware to work with IBC Hooks by adding a
memofield to the IBC transfer message. As discussed in #1413 and based on work by @jhernandezb and @luke-ae.