-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: option to add fee payer account #1159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start. I think there is some confision with payer vs. granter. Please consult the Cosmos SDK team if you have questions what the difference is. I never used this tech.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks.
Do you have an idea how to test the new code?
The sequence of transactions for a complete authz+feegrant are as follows:
The test should execute the above messages sequentially. We can consider Before proceeding with writing this test, I have a query. As mentioned in |
Sounds good, thank you. In #1206 I fixed the outdated docs. Let me know if there are any questions left. |
Anything I can do to help this along? |
Thank you @dckc. I am hesitant to merge this without the feature being tested. I don't want this feature to fail in the user's environment. Also having a test case serves as an always up-to-date example how to use the feature. Writing tests may detect flaws in the API. If you could add tests on top of that PR, I think we can get this out. Please note that on latest main we have Cosmos SDK 0.44 and 0.46 (simapp44/simapp46) test chains. simapp42 was removed. With those chains it should be possible to test the whole flow. |
This PR involves allowing users to set an account as FeePayer, as it is needed for the transaction type
/osmos.authz.v1beta1.MsgExec
to execute.Reference Issue: #1155