Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terra: add autogenerated assetlist and images #343

Merged

Conversation

zhongfu
Copy link
Contributor

@zhongfu zhongfu commented May 8, 2022

Changes:

  • Existing (native) assets should be largely unchanged (except for updated images and the addition of denom aliases)
  • Indentation was changed to 2 spaces per level
  • White Whale address updated with mainnet address (instead of testnet address), and name changed to match Terra CW20 token list

Other things to note:

  • Display names are all set to lower(symbol)
  • CW20 tokens were largely imported as-is from the Terra CW20 token list, so some tokens have weird symbols, e.g. "mIAU (Delisted)"
  • None of the new tokens have CoinGecko IDs or descriptions
  • There's one duplicate symbol for "ChainLink Token" and "Chainlink (Portal)"

script from https://github.com/zhongfu/chain-registry-scripts/tree/master/terra

cw20 token info + images from https://github.com/terra-money/assets/blob/master/cw20/tokens.js (#105)

native tokens from Terra FCD, https://fcd.terra.dev/cosmos/bank/v1beta1/denoms_metadata

native token images from https://github.com/terra-money/assets/tree/master/icon

@JeremyParish69
Copy link
Collaborator

I don't think we should be changing symbols of tokens, which makes me think we shouldn't have (delisted) as part of the symbol, image name, or denom, but that it'd be appropriate fine for the 'Name' field.

@zhongfu
Copy link
Contributor Author

zhongfu commented May 9, 2022

I don't think we should be changing symbols of tokens, which makes me think we shouldn't have (delisted) as part of the symbol, image name, or denom, but that it'd be appropriate fine for the 'Name' field.

I've got some ideas:

  • strip "(Delisted)" out of symbol (and display), and add it to the name, if it isn't already in there
  • replace the info in the terra cw20 list with onchain info, where available
  • send a PR to remove the "(Delisted)" bits from the terra cw20 list

@JeremyParish69
Copy link
Collaborator

I don't think we should be changing symbols of tokens, which makes me think we shouldn't have (delisted) as part of the symbol, image name, or denom, but that it'd be appropriate fine for the 'Name' field.

I've got some ideas:

  • strip "(Delisted)" out of symbol (and display), and add it to the name, if it isn't already in there
  • replace the info in the terra cw20 list with onchain info, where available
  • send a PR to remove the "(Delisted)" bits from the terra cw20 list

Will you be doing that first idea (moving the 'delisted' over to the Name field) in this PR? or you prefer I do that manually after?

@zhongfu
Copy link
Contributor Author

zhongfu commented May 10, 2022

alright, i've gone ahead and done that (+ fixed the PAXG image, and verified that all of the images are actually images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants