Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ORAI base denom and add images #341

Merged
merged 3 commits into from
May 8, 2022

Conversation

zhongfu
Copy link
Contributor

@zhongfu zhongfu commented May 7, 2022

Base denom should be 'uorai', not 'orai'; this denom is mentioned here too

should be 'uorai', not 'orai'
@JeremyParish69
Copy link
Collaborator

Thank you for bringing this up. A few requests, please:
-also change "base": to "uorai"
-(Bonus) for the 6-exponent denom and the "display", make lowercase (the symbol being uppercase means that it will appear as uppercase throughout various UIs)
-(Bonus) upload the token logo images to the local repository under oraichain/images/orai.png + orai.svg

@JeremyParish69 JeremyParish69 self-assigned this May 7, 2022
@zhongfu
Copy link
Contributor Author

zhongfu commented May 8, 2022

Done!

I've also taken the liberty to switch to the black logomark (i.e. logomark-light, png, svg), hope that's fine

@zhongfu zhongfu changed the title Fix ORAI base denom Fix ORAI base denom and add images May 8, 2022
@JeremyParish69 JeremyParish69 merged commit c702e18 into cosmos:master May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants