Update GitHub workflows #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splitbrain
approved these changes
Jan 25, 2024
Functions.php
Outdated
| @@ -43,6 +42,7 @@ public static function register($pdo) | |||
| * @param string $string column value | |||
| * @param string $separator separator added between values | |||
| */ | |||
| // phpcs:ignore PSR1.Methods.CamelCapsMethodName.NotCamelCaps | |||
There was a problem hiding this comment.
any reason why we can't rename this method to groupConcatStep?
There was a problem hiding this comment.
No good reasons, except that I generally avoid renaming public methods. But those two are safe, so I've just renamed them.
Functions.php
Outdated
| @@ -65,6 +65,7 @@ public static function GroupConcatStep(&$context, $rownumber, $string, $separato | |||
| * @param int $rownumber number of rows over which the aggregate was performed. | |||
| * @return null|string | |||
| */ | |||
| // phpcs:ignore PSR1.Methods.CamelCapsMethodName.NotCamelCaps | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new workflow also checks code style, so some fixes are included in this PR.