Skip to content

Fastwiki support #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Fastwiki support #6

merged 2 commits into from
Jun 24, 2019

Conversation

zioth
Copy link
Contributor

@zioth zioth commented Jun 20, 2019

To support drag&drop for the Fastwiki plugin's inline edit and inline section edit features, I did the following:

  • Moved global initialization into an init function.
  • Broke out all event handlers, so they could be turned off before being turned on. This prevents event leaks when the user goes in and out of edit mode. This is why the diff is so large; very little code actually changed.
  • Called init every time fastwiki switched to edit mode.

@zioth zioth mentioned this pull request Jun 20, 2019
@splitbrain
Copy link
Member

LGTM

@annda can you please run this branch to make sure it still works as intended without fastwiki and also fix the travis config when merging?

@annda
Copy link
Contributor

annda commented Jun 20, 2019

Works fine for me. Can't merge though, because of missing write permissions :-(

@splitbrain
Copy link
Member

permissions fixed

@annda annda merged commit 6c1c1c4 into cosmocode:develop Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants