Conversation
Users in navbar
…_task on user change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored code so users are in nav_bar and fingerprints in dropdown. Also not showing whole nav if there is only one user opting instead to invisibly select that. It makes experimenting with the UI much easier.
For this decided to get users via DBus blocking, meaning synchronously, and constructing the whole nav before initializing AppModel. This makes startup slower. but in reality, there is stuff going on anyways. This makes has the additional property of making the code simpler as there was a bunch of asynchronous stuff going on. The other way would've required replacing nav with custom element or doing nav changes in places where self was mutable and it seemed sketchy to me.
Also fixed the icon to be icon_file. Did not get user icon's displayed yet (if it even is possible).