fix: watch being stuck forever on many cancels #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug is triggered when many Watch requests are canceled at the same time, followed by some updates and a new Watch request. The bug doesn't reproduce when using a proper etcd gRPC client vs. a shortcut to call etcd server methods directly. See siderolabs/omni#174 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
frezbo
approved these changes
Apr 26, 2024
|
so the fix is from cosi? |
not quite, the fix is to use a real client to etcd instead of embedded etcd shortcut, here just the test which reproduces the issue and fixes the client in the tests here |
|
/m |
smira
added a commit
to smira/omni
that referenced
this pull request
Apr 26, 2024
Fixes siderolabs#174 The fix is to switch to proper gRPC client to embedded etcd. More information: cosi-project/state-etcd#156 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/omni
that referenced
this pull request
Apr 26, 2024
Fixes siderolabs#174 The fix is to switch to proper gRPC client to embedded etcd. More information: cosi-project/state-etcd#156 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/omni
that referenced
this pull request
Apr 26, 2024
Fixes siderolabs#174 The fix is to switch to proper gRPC client to embedded etcd. More information: cosi-project/state-etcd#156 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/omni
that referenced
this pull request
Apr 26, 2024
Fixes siderolabs#174 The fix is to switch to proper gRPC client to embedded etcd. More information: cosi-project/state-etcd#156 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
ugoenyioha
pushed a commit
to ugoenyioha/omni
that referenced
this pull request
Aug 15, 2025
Fixes #174 The fix is to switch to proper gRPC client to embedded etcd. More information: cosi-project/state-etcd#156 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is triggered when many Watch requests are canceled at the same time, followed by some updates and a new Watch request.
The bug doesn't reproduce when using a proper etcd gRPC client vs. a shortcut to call etcd server methods directly.
See siderolabs/omni#174