Move encryption and decryption configuration options into a separate crypto namespace #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
file_encryption_properties
andfile_decryption_properties
configuration options out of theglobal
Parquet options and into a new config field insideTableParquetOptions
.This allows using
::
as the separator for column specific keys and metadata by avoiding the conflict with the logic forTableParquetOptions::column_specific_options
, and means we can make use of theconfig_namespace_with_hashmap
macro to simplify theConfigField
implementations.It also simplifies the reading configuration by allowing encryption options to be set in the
ParquetReadOptions
rather than needing to modify the session state.I think this also makes more sense conceptually, as these options are likely to be table/file specific rather than something you'd want to set for a whole session.