feat: Prometheus Integration #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus provides a default port allocation list. rabbitmq-cli-consumer is now registered for port 9566.
Closed
|
@corvus-ch Have you had a chance to look at this pull request? |
|
I only had a quick look but definitely need to have a closer one. Some topics I will need to think about:
@estahn Maybe you have some input/ideas for me. |
corvus-ch
requested changes
Apr 14, 2019
There was a problem hiding this comment.
@estahn Thanks for your contribution. I finally took the time to have a closer look (I moved to a new place which always is time consuming). There are a few things I would like be changed if you please can take care of them, I happily will merge this feature.
* Remove unused flag web.message-duration-buckets * Add flag to enable metrics server (metrics, m) * Rename function configuring and starting metrics server Signed-off-by: Enrico Stahn <enrico.stahn@gmail.com>
corvus-ch
reviewed
Apr 18, 2019
corvus-ch
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #63
@corvus-ch Should it be possible to enable/disable this feature?