Skip to content

DC-3562 Integration tests for DataApiV1Sdk.get #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 23, 2022
Merged

DC-3562 Integration tests for DataApiV1Sdk.get #62

merged 11 commits into from
May 23, 2022

Conversation

oleksii-symon-corva-ai
Copy link
Contributor

@oleksii-symon-corva-ai oleksii-symon-corva-ai commented May 17, 2022 •
edited
Loading

Rationale

DataApiV1Sdk.get need integrations tests to be reliable.

Changes

Added integration tests for DataApiV1Sdk.get method.

JIRA ticket

TODO

  • Update CHANGELOG.md

@oleksii-symon-corva-ai oleksii-symon-corva-ai added the enhancement New feature or request label May 17, 2022
@oleksii-symon-corva-ai oleksii-symon-corva-ai changed the base branch from master to feature/api20 May 17, 2022 12:41
finomayato
finomayato reviewed May 17, 2022
View reviewed changes
Copy link

@finomayato finomayato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow we get so many changes in tests/makefiles, at the same time we changed so little in an actual app. Why so?

@oleksii-symon-corva-ai oleksii-symon-corva-ai changed the title DC-3562 Add GET 'data/{provider}/{dataset}/' to DataApiV1Sdk DC-3562 Integration tests for DataApiV1Sdk.get May 18, 2022
@oleksii-symon-corva-ai
Copy link
Contributor Author

Somehow we get so many changes in tests/makefiles, at the same time we changed so little in an actual app. Why so?

DataApiV1Sdk.get method was already there, it lacked integration tests. This pr adds integration tests.

@finomayato

@oleksii-symon-corva-ai oleksii-symon-corva-ai merged commit 13719a3 into feature/api20 May 23, 2022
@oleksii-symon-corva-ai oleksii-symon-corva-ai deleted the feature/dc-3562_add-find-data branch May 23, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ville ville ville approved these changes

@finomayato finomayato Awaiting requested review from finomayato

@corva-alex-s corva-alex-s Awaiting requested review from corva-alex-s

@tsilevych tsilevych Awaiting requested review from tsilevych

Assignees

@oleksii-symon-corva-ai oleksii-symon-corva-ai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksii-symon-corva-ai @ville @finomayato