Skip to content

Commit

Permalink
Keep ES6Proxy enabled in bridgeless mode (facebook#43538)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#43538

The Hermes RuntimeConfig for bridgeless accidentally force-disabled ES6Proxy, resulting in facebook#43523

Let's remove the incorrect override.

To test using RNTester, add the following change:

```
 diff --git a/packages/rn-tester/js/RNTesterAppShared.js b/packages/rn-tester/js/RNTesterAppShared.js
index 87cb6b69dfe..f2512d09c5a 100644
 --- a/packages/rn-tester/js/RNTesterAppShared.js
+++ b/packages/rn-tester/js/RNTesterAppShared.js
@@ -50,6 +50,8 @@ const RNTesterApp = ({
   );
   const colorScheme = useColorScheme();
+  new Proxy({}, {});
+
   const {
     activeModuleKey,
     activeModuleTitle,
```

Before this change, RNTester will get an error at start-up. After, the app loads correctly.

Changelog: [General][Fixed] Correctly keep ES6Proxy for bridgeless mode

Reviewed By: cortinico

Differential Revision: D55045780

fbshipit-source-id: 666b99712d35622f87d42f22a4611851df67d905
  • Loading branch information
fkgozali authored and facebook-github-bot committed Mar 27, 2024
1 parent bfb0319 commit c356309
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ std::unique_ptr<JSRuntime> HermesInstance::createJSRuntime(
.withAllocInYoung(false)
.withRevertToYGAtTTI(true)
.build())
.withES6Proxy(false)
.withEnableSampleProfiling(true)
.withMicrotaskQueue(ReactNativeFeatureFlags::enableMicrotasks())
.withVMExperimentFlags(vmExperimentFlags);
Expand Down

0 comments on commit c356309

Please sign in to comment.