Skip to content

Commit

Permalink
Do not remove libjscexecutor.so from release builds
Browse files Browse the repository at this point in the history
Summary:
As the title says, we dont' want to remove `libjscexecutor.so` when
baking release builds and having JSC enable as this leads to instacrashes.

Fixes facebook#32928
Fixes facebook#32927

Changelog:
[Android] [Fixed] - Do not remove libjscexecutor.so from release builds

Differential Revision: D33681932

fbshipit-source-id: 4a71fd6cfaae35a1f24f048648e32d78d573a457
  • Loading branch information
cortinico authored and facebook-github-bot committed Jan 20, 2022
1 parent 4a227ce commit 8eefa14
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,6 @@ private fun Project.cleanupVMFiles(
} else {
// For JSC, delete all the libhermes* files
it.include("**/libhermes*.so")
// Delete the libjscexecutor from release build
if (cleanup) {
it.include("**/libjscexecutor.so")
}
}
}
.visit { visit ->
Expand Down
4 changes: 0 additions & 4 deletions react.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -372,10 +372,6 @@ afterEvaluate {
} else {
// For JSC, delete all the libhermes* files
include "**/libhermes*.so"
// Delete the libjscexecutor from release build
if (cleanup) {
include "**/libjscexecutor.so"
}
}
}.visit { details ->
def targetVariant1 = ".*/transforms/[^/]*/${variant.name}/.*"
Expand Down

0 comments on commit 8eefa14

Please sign in to comment.