Fix metric name validation to use correct validation scheme method #7087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Tran <trananna@amazon.com>
anna-tran
force-pushed
the
metric-name-validation
branch
from
d6dc7c3 to
56670a1
Compare
|
Thanks for fixing it |
|
We need to cut a new RC to cherry pick this change |
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Nov 4, 2025
…ortexproject#7087) Signed-off-by: Anna Tran <trananna@amazon.com>
yeya24
added a commit
that referenced
this pull request
Nov 4, 2025
* Fix metric name validation to use correct validation scheme method (#7087) Signed-off-by: Anna Tran <trananna@amazon.com> * bump to 1.20.0-rc.1 Signed-off-by: yeya24 <benye@amazon.com> * Fix visit marker race condition (#7082) * update changelog Signed-off-by: yeya24 <benye@amazon.com> --------- Signed-off-by: Anna Tran <trananna@amazon.com> Signed-off-by: yeya24 <benye@amazon.com> Co-authored-by: Anna Tran <trananna@amazon.com> Co-authored-by: Daniel Blando <daniel@blando.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix the metric name validation logic used by distributors when processing remote write requests, by invoking validation around metric name instead of label name.
Which issue(s) this PR fixes:
Fixes #7086
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]