Resource monitor: fix bugs + add tests #6717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Jung <jungjust@amazon.com>
justinjung04
force-pushed
the
resource-monitor-bugfix
branch
from
78e3a99 to
146ff7c
Compare
yeya24
reviewed
Apr 23, 2025
justinjung04
changed the title
Signed-off-by: Justin Jung <jungjust@amazon.com>
justinjung04
force-pushed
the
resource-monitor-bugfix
branch
6 times, most recently
from
d77068f to
f14b01a
Compare
justinjung04
force-pushed
the
resource-monitor-bugfix
branch
from
f14b01a to
060ae2a
Compare
|
@yeya24 can you take a second look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Resource monitor introduced from #6674 contained bugs that were not covered in unit tests.
This PR fixes the bugs and add unit tests to cover them.
Double checked in the dev environment that resource monitor and resource based limiter work as expected:
Which issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]