[Chore] Edit metadata cache supported values description #6252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
component/documentation
type/chore
SungJin1212
force-pushed
the
Edit-metadata-cache-supported-values
branch
from
6b92e6c to
1fd686e
Compare
yeya24
reviewed
Oct 7, 2024
pkg/storage/tsdb/caching_bucket.go
Outdated
| @@ -140,7 +140,7 @@ type MetadataCacheConfig struct { | |||
| } | |||
|
|
|||
| func (cfg *MetadataCacheConfig) RegisterFlagsWithPrefix(f *flag.FlagSet, prefix string) { | |||
| f.StringVar(&cfg.Backend, prefix+"backend", "", fmt.Sprintf("Backend for metadata cache, if not empty. Supported values: %s.", CacheBackendMemcached)) | |||
| f.StringVar(&cfg.Backend, prefix+"backend", "", fmt.Sprintf("Backend for metadata cache, if not empty. Supported values: %s, %s, and '' (disable).", CacheBackendMemcached, CacheBackendRedis)) | |||
There was a problem hiding this comment.
Can we just use an array? Then the flag description can just reference that array. It is easier to maintain IMO
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Edit-metadata-cache-supported-values
branch
from
1fd686e to
60a7b06
Compare
friedrichg
changed the title
yeya24
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit metadata cache backend description to be more accurate.
Which issue(s) this PR fixes:
Fixes
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]