Backfill lower caches on the multi cache implementation #5486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
approved these changes
Jul 26, 2023
yeya24
approved these changes
Jul 26, 2023
alanprot
force-pushed
the
backfill/multicache
branch
from
964e0dd to
07cb373
Compare
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
backfill/multicache
branch
from
07cb373 to
adce1e0
Compare
wenxu1024
pushed a commit
to wenxu1024/cortex
that referenced
this pull request
Jul 26, 2023
…t#5486) Signed-off-by: Alan Protasio <alanprot@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This is the continuation of #5451
With this change we will backfill the cache from the L+1 to L level.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]