-
Notifications
You must be signed in to change notification settings - Fork 820
Fix querier try store gateways on different zones #5476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
reviewed
Jul 25, 2023
812f143
to
963b10f
Compare
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
df034a7
to
746375b
Compare
harry671003
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Ben.
Signed-off-by: Ben Ye <benye@amazon.com>
This seems concerning https://github.com/cortexproject/cortex/actions/runs/5659654449/job/15333902668?pr=5476.
|
alanprot
approved these changes
Jul 25, 2023
Thanks! LGTM |
Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This pr changes
GetClientsFor
method ofBlocksStoreSet
interface to take an additional map of retried zones.blocksStoreReplicationSet
is mainly changed. If zone awareness is not enabled, the logic should be the same. If enabled, the algorithm is:Which issue(s) this PR fixes:
Fixes #5468
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]