Implementing Bucket index sync status file #5446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
bucket-index-sync-status
branch
2 times, most recently
from
d8b1794 to
a4334c5
Compare
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
bucket-index-sync-status
branch
from
a4334c5 to
8490085
Compare
alvinlin123
reviewed
Jul 7, 2023
alvinlin123
reviewed
Jul 7, 2023
alvinlin123
reviewed
Jul 7, 2023
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alvinlin123
reviewed
Jul 11, 2023
| idxs.Status = bucketindex.CustomerManagedKeyError | ||
| // Making the tenant non queryable until 3x the cleanup interval to give time to compactors and storegateways | ||
| // to reload the bucket index in case the key access is re-granted | ||
| idxs.NonQueryableUntil = time.Now().Add(3 * c.cfg.CleanupInterval).Unix() |
There was a problem hiding this comment.
Nit: can we extract the magic number 3 to some meaningfully name constant?
alvinlin123
reviewed
Jul 11, 2023
| if idxs, err := bucketindex.ReadSyncStatus(ctx, i.TSDBState.bucket, userID, logutil.WithContext(ctx, i.logger)); err == nil { | ||
| // Skip blocks shipping if the bucket index failed to sync due to CMK errors. | ||
| if idxs.Status == bucketindex.CustomerManagedKeyError { | ||
| level.Info(logutil.WithContext(ctx, i.logger)).Log("msg", "skipping shipping blocks due CustomerManagedKeyError", "user", userID) |
There was a problem hiding this comment.
Should this be a warn rather than info?
alvinlin123
approved these changes
Jul 11, 2023
|
looks good to me, thanks! |
qinxx108
pushed a commit
to qinxx108/cortex
that referenced
this pull request
Jul 13, 2023
* Implementing Bucket index sync status Signed-off-by: Alan Protasio <alanprot@gmail.com> * fixing bug when returning from cache Signed-off-by: Alan Protasio <alanprot@gmail.com> * Addressing some comments Signed-off-by: Alan Protasio <alanprot@gmail.com> * Changelog Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
alvinlin123
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Implementing Bucket index sync status file (#5446) * Implementing Bucket index sync status Signed-off-by: Alan Protasio <alanprot@gmail.com> * fixing bug when returning from cache Signed-off-by: Alan Protasio <alanprot@gmail.com> * Addressing some comments Signed-off-by: Alan Protasio <alanprot@gmail.com> * Changelog Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com> * Implementing multi level index cache (#5451) Signed-off-by: Yijie Qin <qinyijie@amazon.com> * remove the user from am state replication key Signed-off-by: Yijie Qin <qinyijie@amazon.com> * expose the key label Signed-off-by: Yijie Qin <qinyijie@amazon.com> * add Changelog Signed-off-by: Yijie Qin <qinyijie@amazon.com> * fix comments Signed-off-by: Yijie Qin <qinyijie@amazon.com> * change to use type Signed-off-by: Yijie Qin <qinyijie@amazon.com> * address comment Signed-off-by: Yijie Qin <qinyijie@amazon.com> * fix comment Signed-off-by: Yijie Qin <qinyijie@amazon.com> * use type instead of key Signed-off-by: Yijie Qin <qinyijie@amazon.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com> Co-authored-by: Alan Protasio <approtas@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR introduce a new file to be saved together with the bucket index with the status of the last sync (bucket index update).
The bucket sync status is used on ingesters/queriers/storegateways/compactors to halt any operation for a given tenant if the bucket index could not be updated due CMK errors.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]