Skip to content

Add _total suffix to cached posting compression time metric #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Add _total suffix to cached posting compression time metric #5431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
528d5e9
add _total suffix to cortex_bucket_store_cached_postings_compression_…
yeya24 Jun 28, 2023
6d63750
update changelog
yeya24 Jun 28, 2023
0c1dc92
update test
yeya24 Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* [CHANGE] Ruler: Added user label to `cortex_ruler_write_requests_total`, `cortex_ruler_write_requests_failed_total`, `cortex_ruler_queries_total`, and `cortex_ruler_queries_failed_total` metrics. #5312
* [CHANGE] Alertmanager: Validating new fields on the PagerDuty AM config. #5290
* [CHANGE] Ingester: Creating label `native-histogram-sample` on the `cortex_discarded_samples_total` to keep track of discarded native histogram samples. #5289
* [CHANGE] Store Gateway: Rename `cortex_bucket_store_cached_postings_compression_time_seconds` to `cortex_bucket_store_cached_postings_compression_time_seconds_total`. #5431
* [FEATURE] Store Gateway: Add `max_downloaded_bytes_per_request` to limit max bytes to download per store gateway request.
* [FEATURE] Added 2 flags `-alertmanager.alertmanager-client.grpc-max-send-msg-size` and ` -alertmanager.alertmanager-client.grpc-max-recv-msg-size` to configure alert manager grpc client message size limits. #5338
* [FEATURE] Query Frontend: Add `cortex_rejected_queries_total` metric for throttled queries. #5356
Expand Down
2 changes: 1 addition & 1 deletion pkg/storegateway/bucket_store_metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func NewBucketStoreMetrics() *BucketStoreMetrics {
"Number of postings compression and decompression errors.",
[]string{"op"}, nil),
cachedPostingsCompressionTimeSeconds: prometheus.NewDesc(
"cortex_bucket_store_cached_postings_compression_time_seconds",
"cortex_bucket_store_cached_postings_compression_time_seconds_total",
"Time spent compressing and decompressing postings when storing to / reading from postings cache.",
[]string{"op"}, nil),
cachedPostingsOriginalSizeBytes: prometheus.NewDesc(
Expand Down
8 changes: 4 additions & 4 deletions pkg/storegateway/bucket_store_metrics_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,10 +384,10 @@ func TestBucketStoreMetrics(t *testing.T) {
cortex_bucket_store_cached_postings_compression_errors_total{op="encode"} 1170988
cortex_bucket_store_cached_postings_compression_errors_total{op="decode"} 1193507

# HELP cortex_bucket_store_cached_postings_compression_time_seconds Time spent compressing and decompressing postings when storing to / reading from postings cache.
# TYPE cortex_bucket_store_cached_postings_compression_time_seconds counter
cortex_bucket_store_cached_postings_compression_time_seconds{op="encode"} 1216026
cortex_bucket_store_cached_postings_compression_time_seconds{op="decode"} 1238545
# HELP cortex_bucket_store_cached_postings_compression_time_seconds_total Time spent compressing and decompressing postings when storing to / reading from postings cache.
# TYPE cortex_bucket_store_cached_postings_compression_time_seconds_total counter
cortex_bucket_store_cached_postings_compression_time_seconds_total{op="encode"} 1216026
cortex_bucket_store_cached_postings_compression_time_seconds_total{op="decode"} 1238545

# HELP cortex_bucket_store_cached_postings_original_size_bytes_total Original size of postings stored into cache.
# TYPE cortex_bucket_store_cached_postings_original_size_bytes_total counter
Expand Down