Skip to content

Add additional bucket store metrics #5397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jun 9, 2023

What this PR does:

Add some other bucket store metrics from store gateway. They are:

  • cortex_bucket_store_sent_chunk_size_bytes a histogram to understand how much chunk size per request
  • cortex_bucket_store_postings_size_bytes a histogram to understand how much posting size we have per request
  • cortex_bucket_store_empty_postings_total a counter to know how many empty postings we have

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

yeya24 added 2 commits June 9, 2023 12:11
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24 yeya24 requested a review from friedrichg June 9, 2023 21:02
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@friedrichg friedrichg merged commit e831d91 into cortexproject:master Jun 12, 2023
@yeya24 yeya24 deleted the bucket-store-metrics branch June 12, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants