Skip to content

Enable write autoscaling for active DynamoDB tables #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 14, 2017
Merged

Enable write autoscaling for active DynamoDB tables #507

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f5af96f
Enable autoscaling for dynamodb tables
aaron7 Jul 10, 2017
f0178f5
Add aws autoscaling via dep ensure
aaron7 Jul 10, 2017
3467242
Generate bazel BUILD files
aaron7 Jul 10, 2017
95e2ff9
Update aws and generate bazel BUILD files
aaron7 Jul 10, 2017
72ccd07
Fix zipkin-go-opentracing BUILD files
aaron7 Jul 10, 2017
f1b5877
Tidy up
aaron7 Jul 14, 2017
b01a1e3
Fix tests
aaron7 Aug 9, 2017
66e5485
Only enable auto scale if passed ApplicationAutoScale url
aaron7 Aug 10, 2017
d0f4ab6
Add tests
aaron7 Aug 10, 2017
264be91
Update comment
aaron7 Aug 11, 2017
7ba54e1
Refactor enable/disable branch logic
aaron7 Aug 11, 2017
6cd8278
Fix typos
aaron7 Aug 11, 2017
1b99020
Use autoScalingConfig struct
aaron7 Aug 11, 2017
0a131d9
Simplify cfg copy
aaron7 Aug 11, 2017
fe74a99
Fix typo
aaron7 Aug 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment
  • Loading branch information
@aaron7
aaron7 committed Aug 11, 2017
commit 264be91eb85339e014934bfa668a4c3291a23554
4 changes: 2 additions & 2 deletions pkg/chunk/dynamodb_table_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ var applicationAutoScalingRequestDuration = prometheus.NewHistogramVec(prometheu
Name: "application_autoscaling_request_duration_seconds",
Help: "Time spent doing ApplicationAutoScaling requests.",

// ApplicationAutoScaling latency seems to range from a few ms to a few sec and is
// important. So use 8 buckets from 128us to 2s.
// AWS latency seems to range from a few ms to a few sec. So use 8 buckets
// from 128us to 2s. TODO: Confirm that this is the case for ApplicationAutoScaling.
Buckets: prometheus.ExponentialBuckets(0.000128, 4, 8),
}, []string{"operation", "status_code"})

Expand Down