Skip to content

Graduating stream-chunks-when-using-blocks configuration #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alanprot
Copy link
Member

@alanprot alanprot commented Sep 15, 2022

What this PR does:
This flag is experimental for a long time and seems stable enough to graduate and it has a substantial performance improvement.

From: https://cortexmetrics.io/docs/configuration/v1guarantees/

Flags for configuring whether blocks-ingester streams samples or chunks are temporary, and will be removed when feature is tested.

The client side is not changed to make the rollout smooth.

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alanprot alanprot force-pushed the graduating/stream-chunks-when-using-blocks branch 2 times, most recently from 291d769 to 0415934 Compare September 15, 2022 06:43
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
@alanprot alanprot force-pushed the graduating/stream-chunks-when-using-blocks branch from 22ab781 to db22b9d Compare September 15, 2022 07:40
Signed-off-by: Alan Protasio <approtas@amazon.com>
@alanprot alanprot marked this pull request as ready for review September 15, 2022 07:45
Signed-off-by: Alan Protasio <approtas@amazon.com>
@alanprot alanprot merged commit dd4240d into cortexproject:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants