Respecting -tracing.otel.sample-ratio configuration when enabling OpenTelemetry tracing with X-ray
#4862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
force-pushed
the
tracing-simple-sampler
branch
from
a7dd01c to
85b75fc
Compare
alanprot
changed the title
-tracing.otel.sample-ratio configuration when enabling OpenTelemetry tracing with X-ray
Aneurysm9
reviewed
Sep 14, 2022
Signed-off-by: Alan Protasio <approtas@amazon.com>
alvinlin123
approved these changes
Sep 15, 2022
Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
force-pushed
the
tracing-simple-sampler
branch
from
8debfc5 to
10a3ea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Creates a simple sampler as the
TraceIDRatioBaseddoes not work well with xray generated Ids.See: https://pkg.go.dev/go.opentelemetry.io/contrib/propagators/aws/xray#section-readme
This sampler simple randomly pick traces to be sampled based on the fraction received as parameter. The sample decision is then propagated via the
parentBasedsampler.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]