Switch to Google Analytics 4 using Cortex's dedicated Google account #4814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinlin123
commented
Aug 5, 2022
| @@ -1,9 +1,9 @@ | |||
| {{ if .Path }} | |||
| {{ if .File.Path }} | |||
There was a problem hiding this comment.
This change is because in newer version of Hugo .Path is deprecated, and I saw an warning message during local build.
friedrichg
changed the title
alvinlin123
force-pushed
the
issue-4796-update-google-analytic-lib
branch
from
fc0700d to
bf233d3
Compare
Closed
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123
force-pushed
the
issue-4796-update-google-analytic-lib
branch
from
d93debe to
ed7c7f8
Compare
alanprot
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4796.
After this PR, analytic data would be sent to Cortex's dedicated Google account instead of an individual's Google account.
Few notes
assets/vendor, so current way of using Git Submodule to install Docsy breaks. I can try to fix it, but I found it easier to just switch to using Hugo module, which is also Docsy's current recommended way.