Make s3 bucket lookup type configurable #4794
Conversation
damnever
force-pushed
the
feat/export-s3lookuptype
branch
from
bf3bf0a to
a580215
Compare
damnever
force-pushed
the
feat/export-s3lookuptype
branch
from
a580215 to
c0c6a99
Compare
damnever
force-pushed
the
feat/export-s3lookuptype
branch
from
c0c6a99 to
ff4a96c
Compare
|
@damnever could you fix the lint? |
damnever
force-pushed
the
feat/export-s3lookuptype
branch
2 times, most recently
from
02bcfa0 to
d236e40
Compare
|
@danielblando done |
pkg/storage/bucket/s3/config.go
Outdated
| @@ -95,6 +106,19 @@ func (cfg *Config) Validate() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (cfg *Config) bucketLookupType() s3.BucketLookupType { | |||
There was a problem hiding this comment.
What is your opinion on doing this the same as "BuildThanosConfig()"?
Returning an error when it goes to default which can also return the AutoLookup. The caller can decide what to do. I think at least we are not swallowing any issues.
There was a problem hiding this comment.
What is your opinion on doing this the same as "BuildThanosConfig()"?
We need to convert our string type into s3.BucketLookupType.
Returning an error when it goes to default which can also return the AutoLookup. The caller can decide what to do. I think at least we are not swallowing any issues.
I think Validate is sufficient for our case. However, returning an error is better for other use.
damnever
force-pushed
the
feat/export-s3lookuptype
branch
from
d236e40 to
6a476f8
Compare
|
Seems there are some tests failing now. |
Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
damnever
force-pushed
the
feat/export-s3lookuptype
branch
from
61cb1f4 to
4028435
Compare
Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
damnever
force-pushed
the
feat/export-s3lookuptype
branch
from
4028435 to
5213bb5
Compare
|
LGTM, thanks for the contribution! |
What this PR does:
Which issue(s) this PR fixes:
Some providers may only support one of those bucket lookup styles.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]