fix leaking notifier in ruler when user is removed #4718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinlin123
reviewed
Apr 14, 2022
qinxx108
approved these changes
Apr 14, 2022
roystchiang
force-pushed
the
fix-ruler-leak
branch
4 times, most recently
from
27d1a37 to
ea2db88
Compare
alvinlin123
approved these changes
Apr 14, 2022
roystchiang
force-pushed
the
fix-ruler-leak
branch
2 times, most recently
from
38d2d25 to
a2726ff
Compare
Signed-off-by: Roy Chiang <roychi@amazon.com>
Signed-off-by: Roy Chiang <roychi@amazon.com>
rohang98
force-pushed
the
fix-ruler-leak
branch
2 times, most recently
from
39fbbbc to
c1e43ec
Compare
Signed-off-by: Rohan Gupta <rohdata@amazon.com>
rohang98
force-pushed
the
fix-ruler-leak
branch
from
c1e43ec to
0fbbecb
Compare
Signed-off-by: Rohan Gupta <rohdata@amazon.com>
rohang98
force-pushed
the
fix-ruler-leak
branch
from
71f0260 to
15c7978
Compare
Signed-off-by: Rohan Gupta <rohdata@amazon.com>
Signed-off-by: Rohan Gupta <rohdata@amazon.com>
Signed-off-by: Rohan Gupta <rohdata@amazon.com>
Signed-off-by: Rohan Gupta <rohdata@amazon.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
This reverts commit 7387f2d. Signed-off-by: Alvin Lin <alvinlin@amazon.com>
…ler notifier metrics Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
|
Although all the checks passed, I think we still need update |
roystchiang
force-pushed
the
fix-ruler-leak
branch
from
01e5b11 to
6267cff
Compare
Signed-off-by: Roy Chiang <roychi@amazon.com>
roystchiang
force-pushed
the
fix-ruler-leak
branch
from
6267cff to
6795b07
Compare
|
Thanks for adding the test @roystchiang. I've mark this PR Ready for Review. |
alanprot
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Stops notifier when a user is removed from ruler.
Currently if a user is removed from ruler, the notifier keeps on accumulating. If a cluster has high churn, memory will grow at a faster pace
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]