Run local KES for S3 integration tests #4547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of calling out to play.min.io, run the KES service locally in a container. Generate its key and cert instead of downloading them from GitHub. By depending on fewer third-party services we reduce test failures. Extract function to generate PKI certificates. Update to more recent Minio image; not using the very latest KES because it removed `--root` which is useful. Re-enable the SSE tests (see #4545) Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2 tasks
danielblando
approved these changes
Nov 4, 2021
pracucci
approved these changes
Nov 4, 2021
| "kes", | ||
| images.KES, | ||
| e2e.NewCommandWithoutEntrypoint("sh", "-c", command), | ||
| nil, // KES only supports https calls - TODO make Scenario able to call https or poll plain TCP socket. |
There was a problem hiding this comment.
We have TCPReadinessProbe. Does it work to you?
alvinlin123
approved these changes
Nov 10, 2021
3 tasks
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
Instead of calling out to play.min.io, run the KES service locally in a container. Generate its key and cert instead of downloading them from GitHub. By depending on fewer third-party services we reduce test failures. Extract function to generate PKI certificates. Update to more recent Minio image; not using the very latest KES because it removed `--root` which is useful. Re-enable the SSE tests (see cortexproject#4545) Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
Instead of calling out to play.min.io, run the KES service locally in a container. Generate its key and cert instead of downloading them from GitHub. By depending on fewer third-party services we reduce test failures. Extract function to generate PKI certificates. Update to more recent Minio image; not using the very latest KES because it removed `--root` which is useful. Re-enable the SSE tests (see cortexproject/cortex#4545) Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
Instead of calling out to play.min.io, run the KES service locally in a container. Generate its key and cert instead of downloading them from GitHub. By depending on fewer third-party services we reduce test failures. Extract function to generate PKI certificates. Update to more recent Minio image; not using the very latest KES because it removed `--root` which is useful. Re-enable the SSE tests (see cortexproject#4545) Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Instead of calling out to play.min.io, run the KES service locally in a container.
Generate its key and cert instead of downloading them from GitHub.
By depending on fewer third-party services we reduce test failures.
Extract function to generate PKI certificates.
Update to more recent Minio image; not using the very latest KES because it removed
--rootwhich is useful.Re-enable the SSE tests (see #4545)
Which issue(s) this PR fixes:
Fixes #4543
Checklist