Migrate to dskit/ring #4539
Merged
Migrate to dskit/ring #4539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
treid314
force-pushed
the
dskit_ring
branch
2 times, most recently
from
d2d4081 to
21bcdcb
Compare
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
pracucci
approved these changes
Nov 2, 2021
added 4 commits
November 2, 2021 14:41
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
pracucci
approved these changes
Nov 3, 2021
pstibrany
approved these changes
Nov 3, 2021
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
* Migrate to dskit/ring Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Tidy those mods Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Update docs on my branch Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Wrap multi-tenant alert manager lifecycler registerer with cortex prefix Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Add changelog for new configs brought in via dskit Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Remove whitespace in changelog Signed-off-by: Tyler Reid <tyler.reid@grafana.com> Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
aknuds1
added a commit
to aknuds1/cortex
that referenced
this pull request
Jan 12, 2022
This reverts commit f2656f8. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
pstibrany
pushed a commit
that referenced
this pull request
Jan 13, 2022
aknuds1
added a commit
to aknuds1/cortex
that referenced
this pull request
Jan 13, 2022
This reverts commit f2656f8. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
* Migrate to dskit/ring Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Tidy those mods Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Update docs on my branch Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Wrap multi-tenant alert manager lifecycler registerer with cortex prefix Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Add changelog for new configs brought in via dskit Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Remove whitespace in changelog Signed-off-by: Tyler Reid <tyler.reid@grafana.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
This reverts commit f2656f8. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Reid tyler.reid@grafana.com
What this PR does: This PR migrates cortex to use dskit/ring instead of the local version. This could impact logging as we've moved the dskit ring package off of the global logger and used component loggers instead.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]