Skip to content

fix querier panics when query exemplars #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2021
Merged

fix querier panics when query exemplars #4473

merged 2 commits into from
Sep 13, 2021

Conversation

nous23
Copy link
Contributor

@nous23 nous23 commented Sep 12, 2021

What this PR does:
fix querier panics when query exemplars

Which issue(s) this PR fixes:
Fixes #4469

The panic:

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x14497b5]

goroutine 1295 [running]:
github.com/opentracing-contrib/go-stdlib/nethttp.MiddlewareFunc.func5.1(0xc000a1fc08, 0x2d46780, 0xc00113f560)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/opentracing-contrib/go-stdlib@v1.0.0/nethttp/server.go:150 +0x1ab
panic(0x242fb40, 0x3e2f400)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/runtime/panic.go:965 +0x1b9
github.com/cortexproject/cortex/pkg/util/extract.MetricNameMatcherFromMatchers(0xc000942578, 0x1, 0x1, 0xc000af2e80, 0x20, 0x0, 0x0, 0x14f9b45)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/util/extract/extract.go:58 +0x75
github.com/cortexproject/cortex/pkg/distributor.(*Distributor).GetIngestersForQuery(0xc000664000, 0x2d18a20, 0xc0010b66c0, 0xc000942578, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, ...)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/distributor/query.go:138 +0x133
github.com/cortexproject/cortex/pkg/distributor.(*Distributor).QueryExemplars.func1(0x2d18a20, 0xc0010b66c0, 0x1a, 0xc0469b556a0f3025)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/distributor/query.go:67 +0x119

@nous23
fix querier panics when query exemplars
4b4db03 
Signed-off-by: nous23 <cchen23@outlook.com>
@nous23 nous23 changed the title fix querier panics when query exemplars #4469 fix querier panics when query exemplars Sep 12, 2021
pstibrany
pstibrany approved these changes Sep 12, 2021
View reviewed changes
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pstibrany
Copy link
Contributor

Can you please take a look and fix DCO check? (Unfortunately it's caused by using my suggestion directly from Github UI :( Sorry about that)

https://github.com/cortexproject/cortex/pull/4473/checks?check_run_id=3579017178

@nous23 @pstibrany
Update CHANGELOG.md
277a7fe 
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: nous23 <cchen23@outlook.com>
@nous23
Copy link
Contributor Author

nous23 commented Sep 12, 2021

Done. :)

@pracucci pracucci merged commit 523dde1 into cortexproject:master Sep 13, 2021
@pstibrany pstibrany mentioned this pull request Sep 13, 2021
Closed
2 tasks
@simonswine simonswine mentioned this pull request Sep 21, 2021
Closed
3 tasks
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
@nous23 @pstibrany @alvinlin123
fix querier panics when query exemplars (cortexproject#4473)
2de54a3 
* fix querier panics when query exemplars

Signed-off-by: nous23 <cchen23@outlook.com>

* Update CHANGELOG.md

Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: nous23 <cchen23@outlook.com>

Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pstibrany pstibrany pstibrany approved these changes

@pracucci pracucci pracucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

querier panics when query exemplars

3 participants

@nous23 @pstibrany @pracucci